|
|
24beb34de6
|
Fix: Phase 7-1.2 - Page boundary SEGV in fast free path
## Problem
`bench_random_mixed` crashed with SEGV when freeing malloc allocations
at page boundaries (e.g., ptr=0x7ffff6e00000, ptr-1 unmapped).
## Root Cause
Phase 7 fast free path reads 1-byte header at `ptr-1` without checking
if memory is accessible. When malloc returns page-aligned pointer with
previous page unmapped, reading `ptr-1` causes SEGV.
## Solution
Added `hak_is_memory_readable(ptr-1)` check BEFORE reading header in
`core/tiny_free_fast_v2.inc.h`. Page-boundary allocations route to
slow path (dual-header dispatch) which correctly handles malloc via
__libc_free().
## Verification
- bench_random_mixed (1024B): SEGV → 692K ops/s ✅
- bench_random_mixed (2048B/4096B): SEGV → 697K/643K ops/s ✅
- All sizes stable across 3 runs
## Performance Impact
<1% overhead (mincore() only on fast path miss, ~1-3% of frees)
## Related
- Phase 7-1.1: Dual-header dispatch (Task Agent)
- Phase 7-1.2: Page boundary safety (this fix)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
|
2025-11-08 03:46:35 +09:00 |
|
|
|
48fadea590
|
Phase 7-1.1: Fix 1024B crash (header validation + malloc fallback)
Fixed critical bugs preventing Phase 7 from working with 1024B allocations.
## Bug Fixes (by Task Agent Ultrathink)
1. **Header Validation Missing in Release Builds**
- `core/tiny_region_id.h:73-97` - Removed `#if !HAKMEM_BUILD_RELEASE`
- Always validate magic byte and class_idx (prevents SEGV on Mid/Large)
2. **1024B Malloc Fallback Missing**
- `core/box/hak_alloc_api.inc.h:35-49` - Direct fallback to malloc
- Phase 7 rejects 1024B (needs header) → skip ACE → use malloc
## Test Results
| Test | Result |
|------|--------|
| 128B, 512B, 1023B (Tiny) | +39%~+436% ✅ |
| 1024B only (100 allocs) | 100% success ✅ |
| Mixed 128B+1024B (200) | 100% success ✅ |
| bench_random_mixed 1024B | Still crashes ❌ |
## Known Issue
`bench_random_mixed` with 1024B still crashes (intermittent SEGV).
Simple tests pass, suggesting issue is with complex allocation patterns.
Investigation pending.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Task Agent Ultrathink
|
2025-11-08 03:35:07 +09:00 |
|
|
|
6b1382959c
|
Phase 7-1 PoC: Region-ID Direct Lookup (+39%~+436% improvement!)
Implemented ultra-fast header-based free path that eliminates SuperSlab
lookup bottleneck (100+ cycles → 5-10 cycles).
## Key Changes
1. **Smart Headers** (core/tiny_region_id.h):
- 1-byte header before each allocation stores class_idx
- Memory layout: [Header: 1B] [User data: N-1B]
- Overhead: <2% average (0% for Slab[0] using wasted padding)
2. **Ultra-Fast Allocation** (core/tiny_alloc_fast.inc.h):
- Write header at base: *base = class_idx
- Return user pointer: base + 1
3. **Ultra-Fast Free** (core/tiny_free_fast_v2.inc.h):
- Read class_idx from header (ptr-1): 2-3 cycles
- Push base (ptr-1) to TLS freelist: 3-5 cycles
- Total: 5-10 cycles (vs 500+ cycles current!)
4. **Free Path Integration** (core/box/hak_free_api.inc.h):
- Removed SuperSlab lookup from fast path
- Direct header validation (no lookup needed!)
5. **Size Class Adjustment** (core/hakmem_tiny.h):
- Max tiny size: 1023B (was 1024B)
- 1024B requests → Mid allocator fallback
## Performance Results
| Size | Baseline | Phase 7 | Improvement |
|------|----------|---------|-------------|
| 128B | 1.22M | 6.54M | **+436%** 🚀 |
| 512B | 1.22M | 1.70M | **+39%** |
| 1023B | 1.22M | 1.92M | **+57%** |
## Build & Test
Enable Phase 7:
make HEADER_CLASSIDX=1 bench_random_mixed_hakmem
Run benchmark:
HAKMEM_TINY_USE_SUPERSLAB=1 ./bench_random_mixed_hakmem 10000 128 1234567
## Known Issues
- 1024B requests fallback to Mid allocator (by design)
- Target 40-60M ops/s not yet reached (current: 1.7-6.5M)
- Further optimization needed (TLS capacity tuning, refill optimization)
## Credits
Design: ChatGPT Pro Ultrathink, Claude Code
Implementation: Claude Code with Task Agent Ultrathink support
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
|
2025-11-08 03:18:17 +09:00 |
|
