Files
hakmem/hakmem_pool.d

83 lines
3.2 KiB
D
Raw Normal View History

hakmem_pool.o: core/hakmem_pool.c core/hakmem_pool.h \
core/box/hak_lane_classify.inc.h core/hakmem_config.h \
Phase 29: Pool Hotbox v2 Stats Prune - NO-OP (infrastructure ready) Target: g_pool_hotbox_v2_stats atomics (12 total) in Pool v2 Result: 0.00% impact (code path inactive by default, ENV-gated) Verdict: NO-OP - Maintain compile-out for future-proofing Audit Results: - Classification: 12/12 TELEMETRY (100% observational) - Counters: alloc_calls, alloc_fast, alloc_refill, alloc_refill_fail, alloc_fallback_v1, free_calls, free_fast, free_fallback_v1, page_of_fail_* (4 failure counters) - Verification: All stats/logging only, zero flow control usage - Phase 28 lesson applied: Traced all usages, confirmed no CORRECTNESS Key Finding: Pool v2 OFF by default - Requires HAKMEM_POOL_V2_ENABLED=1 to activate - Benchmark never executes Pool v2 code paths - Compile-out has zero performance impact (code never runs) Implementation (future-ready): - Added HAKMEM_POOL_HOTBOX_V2_STATS_COMPILED (default: 0) - Wrapped 13 atomic write sites in core/hakmem_pool.c - Pattern: #if HAKMEM_POOL_HOTBOX_V2_STATS_COMPILED ... #endif - Expected impact if Pool v2 enabled: +0.3~0.8% (HOT+WARM atomics) A/B Test Results: - Baseline (COMPILED=0): 52.98 M ops/s (±0.43M, 0.81% stdev) - Research (COMPILED=1): 53.31 M ops/s (±0.80M, 1.50% stdev) - Delta: -0.62% (noise, not real effect - code path not active) Critical Lesson Learned (NEW): Phase 29 revealed ENV-gated features can appear on hot paths but never execute. Updated audit checklist: 1. Classify atomics (CORRECTNESS vs TELEMETRY) 2. Verify no flow control usage 3. NEW: Verify code path is ACTIVE in benchmark (check ENV gates) 4. Implement compile-out 5. A/B test Verification methods added to documentation: - rg "getenv.*FEATURE" to check ENV gates - perf record/report to verify execution - Debug printf for quick validation Cumulative Progress (Phase 24-29): - Phase 24 (class stats): +0.93% GO - Phase 25 (free stats): +1.07% GO - Phase 26 (diagnostics): -0.33% NEUTRAL - Phase 27 (unified cache): +0.74% GO - Phase 28 (bg spill): NO-OP (all CORRECTNESS) - Phase 29 (pool v2): NO-OP (inactive code path) - Total: 17 atomics removed, +2.74% improvement Documentation: - PHASE29_POOL_HOTBOX_V2_AUDIT.md: Complete audit with TELEMETRY classification - PHASE29_POOL_HOTBOX_V2_STATS_RESULTS.md: Results + new lesson learned - ATOMIC_PRUNE_CUMULATIVE_SUMMARY.md: Updated with Phase 29 + new checklist - PHASE29_COMPLETE.md: Completion summary with recommendations Decision: Keep compile-out despite NO-OP - Code cleanliness (binary size reduction) - Future-proofing (ready when Pool v2 enabled) - Consistency with Phase 24-28 pattern Generated with Claude Code https://claude.com/claude-code Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2025-12-16 06:33:41 +09:00
core/hakmem_features.h core/hakmem_build_flags.h core/hakmem_internal.h \
core/hakmem.h core/hakmem_sys.h core/hakmem_whale.h \
core/box/ptr_type_box.h core/box/pool_hotbox_v2_header_box.h \
core/hakmem_syscall.h core/box/pool_hotbox_v2_box.h core/hakmem_pool.h \
core/box/pool_zero_mode_box.h core/box/../hakmem_env_cache.h \
core/hakmem_prof.h core/hakmem_policy.h core/hakmem_debug.h \
core/box/pool_tls_types.inc.h core/box/pool_mid_desc.inc.h \
core/box/pool_mid_tc.inc.h core/box/pool_mf2_types.inc.h \
core/box/pool_mf2_helpers.inc.h core/box/pool_mf2_adoption.inc.h \
core/box/pool_tls_core.inc.h core/box/pool_refill.inc.h \
core/box/pool_init_api.inc.h core/box/pool_stats.inc.h \
core/box/pool_api.inc.h core/box/pagefault_telemetry_box.h \
core/box/pool_hotbox_v2_box.h core/box/tiny_heap_env_box.h \
core/box/c7_hotpath_env_box.h core/box/pool_zero_mode_box.h \
core/box/pool_config_box.h core/box/../hakmem_build_flags.h \
core/box/pool_stats_box.h core/box/pool_config_box.h \
core/box/pool_mid_desc_cache_box.h core/box/pool_free_v1_box.h \
core/box/pool_stats_box.h core/box/pool_mid_desc_cache_box.h \
core/box/pool_mid_inuse_deferred_box.h \
core/box/pool_mid_inuse_deferred_env_box.h \
core/box/pool_mid_inuse_tls_pagemap_box.h \
core/box/pool_mid_inuse_deferred_stats_box.h \
core/box/pool_block_to_user_box.h core/box/pool_free_v2_box.h \
core/box/pool_block_to_user_box.h core/box/pool_hotbox_v2_box.h \
core/box/pool_alloc_v1_flat_box.h core/box/pool_alloc_v2_box.h \
core/box/pool_alloc_v1_box.h
core/hakmem_pool.h:
core/box/hak_lane_classify.inc.h:
core/hakmem_config.h:
core/hakmem_features.h:
Phase 29: Pool Hotbox v2 Stats Prune - NO-OP (infrastructure ready) Target: g_pool_hotbox_v2_stats atomics (12 total) in Pool v2 Result: 0.00% impact (code path inactive by default, ENV-gated) Verdict: NO-OP - Maintain compile-out for future-proofing Audit Results: - Classification: 12/12 TELEMETRY (100% observational) - Counters: alloc_calls, alloc_fast, alloc_refill, alloc_refill_fail, alloc_fallback_v1, free_calls, free_fast, free_fallback_v1, page_of_fail_* (4 failure counters) - Verification: All stats/logging only, zero flow control usage - Phase 28 lesson applied: Traced all usages, confirmed no CORRECTNESS Key Finding: Pool v2 OFF by default - Requires HAKMEM_POOL_V2_ENABLED=1 to activate - Benchmark never executes Pool v2 code paths - Compile-out has zero performance impact (code never runs) Implementation (future-ready): - Added HAKMEM_POOL_HOTBOX_V2_STATS_COMPILED (default: 0) - Wrapped 13 atomic write sites in core/hakmem_pool.c - Pattern: #if HAKMEM_POOL_HOTBOX_V2_STATS_COMPILED ... #endif - Expected impact if Pool v2 enabled: +0.3~0.8% (HOT+WARM atomics) A/B Test Results: - Baseline (COMPILED=0): 52.98 M ops/s (±0.43M, 0.81% stdev) - Research (COMPILED=1): 53.31 M ops/s (±0.80M, 1.50% stdev) - Delta: -0.62% (noise, not real effect - code path not active) Critical Lesson Learned (NEW): Phase 29 revealed ENV-gated features can appear on hot paths but never execute. Updated audit checklist: 1. Classify atomics (CORRECTNESS vs TELEMETRY) 2. Verify no flow control usage 3. NEW: Verify code path is ACTIVE in benchmark (check ENV gates) 4. Implement compile-out 5. A/B test Verification methods added to documentation: - rg "getenv.*FEATURE" to check ENV gates - perf record/report to verify execution - Debug printf for quick validation Cumulative Progress (Phase 24-29): - Phase 24 (class stats): +0.93% GO - Phase 25 (free stats): +1.07% GO - Phase 26 (diagnostics): -0.33% NEUTRAL - Phase 27 (unified cache): +0.74% GO - Phase 28 (bg spill): NO-OP (all CORRECTNESS) - Phase 29 (pool v2): NO-OP (inactive code path) - Total: 17 atomics removed, +2.74% improvement Documentation: - PHASE29_POOL_HOTBOX_V2_AUDIT.md: Complete audit with TELEMETRY classification - PHASE29_POOL_HOTBOX_V2_STATS_RESULTS.md: Results + new lesson learned - ATOMIC_PRUNE_CUMULATIVE_SUMMARY.md: Updated with Phase 29 + new checklist - PHASE29_COMPLETE.md: Completion summary with recommendations Decision: Keep compile-out despite NO-OP - Code cleanliness (binary size reduction) - Future-proofing (ready when Pool v2 enabled) - Consistency with Phase 24-28 pattern Generated with Claude Code https://claude.com/claude-code Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2025-12-16 06:33:41 +09:00
core/hakmem_build_flags.h:
core/hakmem_internal.h:
core/hakmem.h:
core/hakmem_sys.h:
core/hakmem_whale.h:
core/box/ptr_type_box.h:
core/box/pool_hotbox_v2_header_box.h:
core/hakmem_syscall.h:
core/box/pool_hotbox_v2_box.h:
core/hakmem_pool.h:
core/box/pool_zero_mode_box.h:
core/box/../hakmem_env_cache.h:
core/hakmem_prof.h:
core/hakmem_policy.h:
core/hakmem_debug.h:
core/box/pool_tls_types.inc.h:
core/box/pool_mid_desc.inc.h:
core/box/pool_mid_tc.inc.h:
core/box/pool_mf2_types.inc.h:
core/box/pool_mf2_helpers.inc.h:
core/box/pool_mf2_adoption.inc.h:
core/box/pool_tls_core.inc.h:
core/box/pool_refill.inc.h:
core/box/pool_init_api.inc.h:
core/box/pool_stats.inc.h:
core/box/pool_api.inc.h:
Phase 23 Unified Cache + PageFaultTelemetry generalization: Mid/VM page-fault bottleneck identified Summary: - Phase 23 Unified Cache: +30% improvement (Random Mixed 256B: 18.18M → 23.68M ops/s) - PageFaultTelemetry: Extended to generic buckets (C0-C7, MID, L25, SSM) - Measurement-driven decision: Mid/VM page-faults (80-100K) >> Tiny (6K) → prioritize Mid/VM optimization Phase 23 Changes: 1. Unified Cache implementation (core/front/tiny_unified_cache.{c,h}) - Direct SuperSlab carve (TLS SLL bypass) - Self-contained pop-or-refill pattern - ENV: HAKMEM_TINY_UNIFIED_CACHE=1, HAKMEM_TINY_UNIFIED_C{0-7}=128 2. Fast path pruning (tiny_alloc_fast.inc.h, tiny_free_fast_v2.inc.h) - Unified ON → direct cache access (skip all intermediate layers) - Alloc: unified_cache_pop_or_refill() → immediate fail to slow - Free: unified_cache_push() → fallback to SLL only if full PageFaultTelemetry Changes: 3. Generic bucket architecture (core/box/pagefault_telemetry_box.{c,h}) - PF_BUCKET_{C0-C7, MID, L25, SSM} for domain-specific measurement - Integration: hak_pool_try_alloc(), l25_alloc_new_run(), shared_pool_allocate_superslab_unlocked() 4. Measurement results (Random Mixed 500K / 256B): - Tiny C2-C7: 2-33 pages, high reuse (64-3.8 touches/page) - SSM: 512 pages (initialization footprint) - MID/L25: 0 (unused in this workload) - Mid/Large VM benchmarks: 80-100K page-faults (13-16x higher than Tiny) Ring Cache Enhancements: 5. Hot Ring Cache (core/front/tiny_ring_cache.{c,h}) - ENV: HAKMEM_TINY_HOT_RING_ENABLE=1, HAKMEM_TINY_HOT_RING_C{0-7}=size - Conditional compilation cleanup Documentation: 6. Analysis reports - RANDOM_MIXED_BOTTLENECK_ANALYSIS.md: Page-fault breakdown - RANDOM_MIXED_SUMMARY.md: Phase 23 summary - RING_CACHE_ACTIVATION_GUIDE.md: Ring cache usage - CURRENT_TASK.md: Updated with Phase 23 results and Phase 24 plan Next Steps (Phase 24): - Target: Mid/VM PageArena/HotSpanBox (page-fault reduction 80-100K → 30-40K) - Tiny SSM optimization deferred (low ROI, ~6K page-faults already optimal) - Expected improvement: +30-50% for Mid/Large workloads Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-17 02:47:58 +09:00
core/box/pagefault_telemetry_box.h:
core/box/pool_hotbox_v2_box.h:
core/box/tiny_heap_env_box.h:
core/box/c7_hotpath_env_box.h:
core/box/pool_zero_mode_box.h:
core/box/pool_config_box.h:
core/box/../hakmem_build_flags.h:
core/box/pool_stats_box.h:
core/box/pool_config_box.h:
core/box/pool_mid_desc_cache_box.h:
core/box/pool_free_v1_box.h:
core/box/pool_stats_box.h:
core/box/pool_mid_desc_cache_box.h:
core/box/pool_mid_inuse_deferred_box.h:
core/box/pool_mid_inuse_deferred_env_box.h:
core/box/pool_mid_inuse_tls_pagemap_box.h:
core/box/pool_mid_inuse_deferred_stats_box.h:
core/box/pool_block_to_user_box.h:
core/box/pool_free_v2_box.h:
core/box/pool_block_to_user_box.h:
core/box/pool_hotbox_v2_box.h:
core/box/pool_alloc_v1_flat_box.h:
core/box/pool_alloc_v2_box.h:
core/box/pool_alloc_v1_box.h: